ENH Add configuration to cap report counts for large datasets. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jan 21, 2022
|
@emteknetnz Will make those changes as time permits - hopefully in the next week. |
|
will this get merged? |
I haven't had time to make the requested changes yet. |
|
Hopefully it can be added. It is a good one. |
|
I'd set the default limit to 10,000. I think it is good to have default limits on things. People can always increase it and |
|
@emteknetnz What do you think about @sunnysideup's suggestion? Happy to make the change if it's approved. |
|
Requested changes to date have been made, and tests are passing. |
|
Yup 10,000 default limit makes sense - presumably you'd add just add |
|
Yeah and I'll update the test and docs to match. Sounds like a plan. |
Opted not to return the result from `getCount()` directly since the PHPDoc says this returns an int (even though it technically already returns a string if the report isn't set up correctly...)
|
@emteknetnz I've added the default and updated the readme and test. |
emteknetnz
approved these changes
Jan 31, 2022
GuySartorelli
added a commit
to GuySartorelli/silverstripe-contentreview
that referenced
this pull request
Mar 6, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
GuySartorelli
added a commit
to GuySartorelli/silverstripe-contentreview
that referenced
this pull request
Mar 7, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
GuySartorelli
added a commit
to GuySartorelli/silverstripe-contentreview
that referenced
this pull request
Mar 7, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
GuySartorelli
added a commit
to GuySartorelli/silverstripe-contentreview
that referenced
this pull request
Mar 7, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
GuySartorelli
added a commit
to GuySartorelli/silverstripe-contentreview
that referenced
this pull request
Mar 9, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
GuySartorelli
added a commit
to GuySartorelli/silverstripe-contentreview
that referenced
this pull request
Mar 9, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
GuySartorelli
added a commit
to GuySartorelli/silverstripe-contentreview
that referenced
this pull request
Mar 10, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
emteknetnz
pushed a commit
to silverstripe/silverstripe-contentreview
that referenced
this pull request
Mar 10, 2022
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Opted not to return the result from
getCount()directly since the PHPDoc says this returns an int (even though it technically already returns a string if the report isn't set up correctly...)